-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/update-report: nudge people to tweak settings. #14592
Conversation
Review period will end on 2023-02-13 at 19:28:49 UTC. |
This makes sense to me and I agree that it should probably wait until we're sure that installing from the API is stable. |
This seems reasonable, I agree. A week of no bug reports could be the target before merging this. |
@RandomDSdevel want to explain the drive-by 👎🏻? |
👍🏻 good call. |
So that comes from a couple inter-related points that I originally refrained from bringing up immediately, at least partly so as not to derail the thread. I'll break these up a bit by category and/or environment variable:
I just made a note to myself to set the Git configuration setting also introduced by this PR before running ' |
Something just to clarify here, in case it wasn't known: this message would only display once and never again (like the analytics message). |
I know; I was just noting that the Git configuration setting's there to stop it from appearing at all if you don't want to see it and/or it's just noise for you. It's so trivial it barely registers as an inconvenvince or blip on the radar, though. (Continues carrying on with things.) |
For future reference: I consider a 👎🏻 with no comments to be pretty rude. If GitHub gave me the ability to disable: I would. In future: please drop a comment instead of a drive-by negative reaction, thanks ❤️
I still think there's value for those users. I've been beta-testing the API for months and have found Homebrew to be generally faster and less annoying when doing so.
Yup, this. All of the other points I feel are pretty easily dismissed with "this is a message you will see once per machine and can then choose to ignore it". |
Review period ended. |
I've also updated this PR to nudge people on analytics settings so we can hopefully get some more people back to using analytics once we're off Google. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with this. I suggest the same timeline of a week with no issues before shipping this.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Note: I am still planning on landing this, I was just waiting for:
|
Been working on a couple of those, but had no time this week. Will get a couple PRs up this weekend. |
@Bo98 Thanks! If you don't get the chance to open working PRs, feel free to push broken draft PRs. Similarly, if you're even before that but close to a solution: note in the issue or assign yourself so I don't duplicate your work. 🙇🏻 |
Nudge people who have set update or analytics related settings to change them and to run `brew untap` for taps they no longer need.
Last |
@MikeMcQuaid I haven't traced the cause yet, but I received a prompt today on my second machine to
But Is there a way I can easily get |
@bevanjkay should be fixed by #15637 |
Nudge people who have set update-related settings to change them.
Inspired by @Bo98 pointing out we may not "get back" people who disabled the API.
It probably makes sense to hold off until 4.0.1 or later rather than 4.0.0 for this just so they get the most stable experience.
I will also add this to the 4.0.0 release notes.